Dawn settings update #3683
Dawn settings update #3683
Conversation
| "paragraph": "Affects areas like navigation dropdowns, pop-up modals, and cart pop-ups." | ||
| "paragraph": "Affects areas like navigation dropdowns and pop-up modals and carts" |
There was a problem hiding this comment.
Something about this new sentence feels a bit off; these settings don't apply to the whole cart, nor is the cart a "pop-up cart".
Since it also doesn't really shorten things I'm thinking it's better left off.
| "label": "Popup notification" | ||
| "label": "Popup" |
There was a problem hiding this comment.
The whole cart isn't a pop up with this setting; it uses the "Page" layout, but with an added pop up notification when an item is added to cart.
| "info": "Visible when cart drawer is empty." | ||
| "info": "Shown when cart is empty" |
There was a problem hiding this comment.
The collection only shows when the cart is empty and is in drawer mode; in page or popup notification it's not displayed.
| @@ -443,42 +436,41 @@ | |||
| "options__8": { | |||
| "label": "Round" | |||
| }, | |||
| "label": "Image shape", | |||
| "info": "Standard-styled cards have no borders when an image shape is active." | |||
There was a problem hiding this comment.
I think this info one is necessary, as it changes the behaviour of the border setting (no more borders when a shape is used instead of the default)
| "label": "Show icons on desktop" | ||
| "label": "Icons" |
There was a problem hiding this comment.
This only applies to desktop, so might be worth keeping that mention
| "label": "1 column" | ||
| }, | ||
| "options__2": { | ||
| "label": "2 columns" |
There was a problem hiding this comment.
Should this align with other instances where we only use 1 / 2, like line 1917?
| @@ -2727,8 +2699,7 @@ | |||
| }, | |||
| "options__4": { | |||
| "label": "Large" | |||
| }, | |||
| "info": "For best results, use an image with a 16:9 aspect ratio. [Learn more](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" | |||
There was a problem hiding this comment.
Similar to previous comments about mentioning aspect ratio
| }, | ||
| "show_text_below": { | ||
| "label": "Show content below image on mobile", | ||
| "info": "For best results, use an image with a 16:9 aspect ratio. [Learn more](https://help.shopify.com/manual/shopify-admin/productivity-tools/image-editor#understanding-image-aspect-ratio)" |
There was a problem hiding this comment.
Similar to previous comments about mentioning aspect ratio
| @@ -1168,7 +1160,7 @@ | |||
| "content": "Mobile layout" | |||
There was a problem hiding this comment.
Other settings use "Mobile Layout" (double capital)
| "button_label": { | ||
| "label": "Button label", | ||
| "info": "Leave the label blank to hide the button.", |
There was a problem hiding this comment.
Other similar mentions weren't removed (ex L#1317).
Should this stay?
PR Summary:
Why are these changes introduced?
Fixes #0.
What approach did you take?
Other considerations
Decision log
Visual impact on existing themes
Testing steps/scenarios
Demo links
Checklist